👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/341768

I agree with you. I was under the impression https://github.com/github/primer/issues/3922 was not part of the current epic and we would only work on it next quarter with https://github.com/github/primer/issues/3399:)

Happy to update the designs

Since the empty state is officially part of the mockups design provided, I think we should avoid supporting an official "No matches" item and encourage teams to migrate.

I'm not sure if I agree on the last bit about encourage teams to migrate. It would help us to have a default no-results state that matches the new design with the option to customise the message.

Update: On second thoughts, given how loading states (https://github.com/github/primer/issues/3921) is very similar design wise. I think we should address this after merging that.

Closing this PR because there isn't much in this PR that would carry through

I agree with you. I was under the impression https://github.com/github/primer/issues/3922 was not part of the current epic and we would only work on it next quarter with https://github.com/github/primer/issues/3399)

Ah yeah, I think this work was originally scoped under #3399 but I moved it into the group of issues due 9/27 because it's related pretty directly to accessibility.

I'm not sure if I agree on the last bit about encourage teams to migrate. It would help us to have a default no-results state that matches the new design with the option to customise the message.

The good news is that "No matches" items will continue to work, so teams can either migrate and reap the accessibility rewards or choose to stick with what they already have and maintain existing functionality.

On second thoughts, given how loading states (https://github.com/github/primer/issues/3921) is very similar design wise. I think we should address this after merging that.

Yes! That was my thinking as well.